Implements Python error hint when importing from src.
#5407
Conversation
CodSpeed Performance ReportMerging #5407 will not alter performanceComparing Summary
Footnotes
|
dom96
force-pushed
the
dominik/src-import-better-error
branch
from
444565f to
206f59a
Compare
| exc.add_note( | ||
| "If your main module is inside the 'src' directory then your import " + | ||
| "statement shouldn't include a 'src.' prefix") | ||
| raise exc |
There was a problem hiding this comment.
To avoid memory leaks you should do:
try:
raise exc
finally:
del exc
Or ideally move the whole thing into a Python try/catch.
It's important to remember that exceptions hold references to frame objects so keeping them alive also keeps all the local variables from all those scopes alive.
|
What about if the import happens in the fetch handler? |
| pyodide.runPython(` | ||
| import sys | ||
| exc = sys.last_value | ||
| if exc.name == "src": |
There was a problem hiding this comment.
This will raise an attribute error if exc doesn't have a name attribute. You need to check if it's a ModuleNotFoundError.
There was a problem hiding this comment.
If the test suite is currently passing let's make sure there's a test where some other error is raised at top level and make sure it doesn't get messed up.
2 participants
Test is in EW because wd-test doesn't make it easy to assert on script startup failures afaik.
Test Plan